clear useless declarations or include

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

remove duplicated code in ClientSideEncryption class

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

remove wrong conversions from or to base64

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fixes wrong conversion from or to base64 encoding

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fixes for software end-to-end encryption issues

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix setting up encryption with software based certificate storage

some data need to be converted to or from base64

some data should not be converted

clear one such place where a conversion to base64 was too much

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

disable some parts of the auto tests for end-to-end encryption

those tests are now broken and we think they do not bring much value

for now parts of them will be disabled until we get better automated
tests

realized while doing this that the secure drop tests are not independent
of each other

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

partial fix for broken automated tests

will use different validation method for hardware stored certificates
and pure software certificates emited by the nextcloud server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

add support to use PKCS#11 harware token to store certifice for e2ee

Close #5685

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7809 from nextcloud/bugfix/perms

Adds some extra info when throwing exception with setting folder permissions.

Improve logging when error occurs while changing folder permissions.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7824 from nextcloud/feature/ncfpk-2.0

shell_integration/macOS: Upgrade to NextcloudFileProviderKit 2.0

shell_integration/macOS/FileProviderUIExt: Use valid NKError description property

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

shell_integration/macOS/FileProviderExt: Do not delete an item twice in FileProviderExtension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

shell_integration/macOS/FileProviderUIExt: Adapt MetadataProvider utility methods to NextcloudKit 5

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

shell_integration/macOS/FileProviderUIExt: Adapt FileProviderUIExt sharing to NextcloudKit 5

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

shell_integration/macOS/FileProviderUIExt: Adapt FileProviderUIExt Locking to NextcloudKit 5

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

shell_integration/macOS/FileProviderExt: Adapt to API changes in NextcloudFileProviderKit changes in 2.0

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

shell_integration/macOS: Pin to NextcloudFileProviderKit stable-2.0

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7819 from nextcloud/bugfix/lowerDiscoveryLogsImpact

only use debug log level for discovery traces to decrease cost

only use debug log level for discovery traces to decrease cost

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7825 from nextcloud/bugfix/craft-ini-2501

craft: Upgrade to binary cache 25.01

craft: Clean up ini file

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

craft: Upgrade to binary cache 25.01 and Qt version 6.8.1

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

craft: Only set NSIS package type with windows

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7812 from nextcloud/bugfix/fluent-style

use correct qml style on Windows

use correct qml style on Windows

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #7422 from Integral-Tech/qstring-refactor

refactor: replace QString() with QStringLiteral() for better performance

refactor: replace QString() with QStringLiteral() for better performance

Signed-off-by: Integral <integral@member.fsf.org>

Merge pull request #7755 from nextcloud/bugfix/icons-darkmode

fix colours in dark mode

fix colours in dark mode

- use placeholderText for TextField icons (introduced in Qt 5.12)
- use windowText for the large icons in activity view/search results
- also fix retrieval of icons from the server

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #7811 from nextcloud/Rello-patch-2

Update doc link in issue template

Update BUG_REPORT.yml

Signed-off-by: Rello <Rello@users.noreply.github.com>

Merge pull request #7810 from nextcloud/Rello-patch-1

Link to new documentation

Link to new documentation

Signed-off-by: Rello <Rello@users.noreply.github.com>

Delete .github/workflows/documentation.yml

Documentation was moved to
https://github.com/nextcloud/documentation

Signed-off-by: Rello <Rello@users.noreply.github.com>

Merge pull request #7801 from nextcloud/plucky

Add Ubuntu Plucky

Add Ubuntu Plucky

Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>

Merge pull request #7799 from nextcloud/bugfix/fixAgainEndToEndEncryptionKeyGeneration

fix wrong if condition

fix wrong if condition

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7416 from nextcloud/feature/windowsQmlStyleFluent

use new in Qt6.8 windows fluent style

on windows use Qt FluentWinUI3 style unless win10: Universal

use Universal qmt style on windows release before windows 11 then use
FluentWinUI3 which should fit with default windows 11 native style

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

switch to latest Qt 6.8.1 ci image

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Remove transparency value from system colours where needed

For some reason Windows11 has some transparency in the system colours
which makes reading drawers difficult

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

switch drone ci to Qt 6.8.0 based images

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

require Qt 6.8.0

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

use new in Qt6.8 windows fluent style

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7768 from nextcloud/bugfix/relogin-after-initial-setup-wizard

persist credentials retrieved through the wizard

persist credentials retrieved through the wizard

When setting up an account through the wizard for the first time, the
credentials are not saved properly.  This requires the user to sign in
again after an application restart.

At least for the login flow v2 case, the `WebFlowCredentials` class
eventually persists the retrieved credentials, whereas the class used
within the wizard (`OCC::Flow2AuthCredsPage`) doesn't.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #7789 from nextcloud/bugfix/show-resolve-conflicts-dialog

fix "Resolve conflicts" dialog not showing up

fix "Resolve conflicts" dialog not showing up

commit 00b616ba9d92a492b0c4e5101b58fff6506591ef removed the call to
`QScopedPointer::take` as it's considered deprecated in Qt 6.1 and
advises to use `std::unique_ptr` with `release()` instead

--> replace `QScopedPointer` with `std::unique_ptr` and call its
`release()` method as part of the cast to `QQuickWindow*`

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #7786 from nextcloud/bugfix/correct-link-call-dialog

notifications: Do not assume root activity link is the correct "join call" link

Do not assume root activity link is the correct "join call" link

Use the link in the activity's 'links'

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7782 from nextcloud/feature/client-alma8

modify AppImage build script to work with an EL8 base

use latest appimage build docker image

see https://github.com/nextcloud/docker-ci/pkgs/container/continuous-integration-client-appimage-qt6/342431972?tag=client-appimage-el8-6.8.1-2

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

update AppImage build comment text

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

update the drone signature

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

replace drone PR appimage setup with GitHub Actions

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

start using the EL8 image for building the appimage

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

gitignore: add .cache and *.AppImage

.cache is used by clangd on my setup; built AppImages also shouldn't be
part of the repo

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

modify appimage build script to work with an EL8 base

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7718 from Diff-fusion/improve-log-speed

Log path strings directly instead of accumulating

Check if discovery paths are empty before logging

Signed-off-by: Felix <felix-git@0xf.eu>

Log path strings directly instead of accumulating

Signed-off-by: Felix <felix-git@0xf.eu>

Merge pull request #7780 from nextcloud/feature/cleanDeprecatedHashAlgorithm

switch client side encryption to use sha256 hash algorithm

switch client side encryption to use sha256 hash algorithm

Close #5989

only support sha1 for depreceted read-only usage

use sha256 for new encrypted write operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7772 from nextcloud/feature/capabilities-chunk-size-server

sync: Respect maximum chunk size provided in server capabilities

Apply max concurrent chunk uploads retrieved from server capabilities

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Expose maxConcurrentChunkUploads from Capabilities

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove overrideServerChunkSize config entry

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Actually call overrideServerChunkSize

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not apply max capabilities chunk size as min chunk size too

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix capsMaxChunkSize comparison

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove extraneous parenthesis

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix naming for overrideSercerChunkSize constexpr

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add config entry to override server chunk size

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Enforce chunk size provided by server capabilities

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Override config chunk sizing values with max chunk size retrieved from capabilities

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add maxChunkSize getter function to get chunked upload max size from capabilities

This will be added with NC31

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7754 from nextcloud/Rello-patch-1

Make Brander QT selection dynamic

Update craftmaster.ini

Co-authored-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Rello <Rello@users.noreply.github.com>

Update VERSION.cmake

Signed-off-by: Rello <Rello@users.noreply.github.com>

Update craftmaster.ini

Signed-off-by: Rello <Rello@users.noreply.github.com>

Merge pull request #7781 from nextcloud/bugfix/readOnlyClassicalSyncLnkShortcutsWindows

fix the if check for invalid virtual LNK files

fix the if check for invalid virtual LNK files

should ensure we fix the DB metadata of LNK windows shortcuts with
virtual files type

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7779 from nextcloud/bugfix/readOnlyClassicalSyncLnkShortcutsWindows

Bugfix/read only classical sync lnk shortcuts windows

update metadata when a file item has wrong type in DB

should help fixing the type of windows shortcuts in DB that were wrongly
set as virtual files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

add an assert to ensure we do not use virtual file types with no VFS

if VFS mode is off, we should nto be using any virtual file types

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

handle LNK virtual files only when VFS mode is not off

should ensure lnk widnows shortcut files are not mistakenly handled as
virtual files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7769 from nextcloud/perf/color-conversion

Avoid converting string to color